Dan Kenigsberg has posted comments on this change.
Change subject: Move fencing logic out of API.py
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
I wish I had a unit test for API.Global.fenceAgent so I could assume that at
least the basic stuff is working...
....................................................
File vdsm_api/vdsmapi-schema.json
Line 305: #
Line 306: # Since: 4.10.0
Line 307: ##
Line 308: {'command': {'class': 'Global', 'name': 'fenceNode'},
Line 309: 'data': {'addr': 'str', 'bladePort': 'int', 'agent': 'str',
'username': 'str',
nope, you haven't changed the type.
Line 310: 'password': 'str', 'action': 'FenceNodeAction', '*secure':
'bool',
Line 311: '*options': 'str'},
Line 312: 'returns': {'*power': 'FenceNodePowerStatus'}}
Line 313:
--
To view, visit http://gerrit.ovirt.org/7190
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I944c6548a42612f705a410fb4290215451bca035
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
