Francesco Romani has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 8: (3 comments) initial review, need more time to difest sslutils.py and friends. First scan looks good however. https://gerrit.ovirt.org/#/c/44494/8/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: try: I'm not sure this is what Nir meant in a past comment, IIUC he suggested to use the existing compat.py. Not important enough to stop this patch, however. Line 21: from . import m2cutils as sslutils Line 22: from .m2cutils import SSLSocket Line 23: from .m2cutils import SSLHandshakeDispatcher Line 24: except ImportError: Line 25: from . import sslutils Line 26: from .sslutils import SSLHandshakeDispatcher Line 27: from ssl import SSLSocket Line 28: Line 29: # we need it to satisfy pyflakes does this block need to be indented? Just asking, not sure about what python wants here. This can raise some warning/error in the ssl path. Line 30: sslutils Line 31: SSLHandshakeDispatcher https://gerrit.ovirt.org/#/c/44494/8/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 25: import ssl Line 26: import xmlrpclib Line 27: Line 28: from vdsm.utils import ( Line 29: monotonic_time, no need for parens, but not that important. Line 30: ) Line 31: from .config import config Line 32: Line 33: -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
