Michal Skrivanek has posted comments on this change. Change subject: virt: add logic for POWER cpu xml element ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/42736/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 357: where {X} is the binary compatibility version of POWER that we Line 358: require (6, 7, 8). This translates to qemu's -cpu host,compat=power{X}. Line 359: Line 360: Using the second option does not limit migration between POWER8 Line 361: machines - it is still possible to migrate from e.g. POWER8 to POWER8e. actually, you describe the second option in a way which suggests that we support it as an option, but the code below disagrees:) Please make it more clear Line 362: """ Line 363: Line 364: cpu = Element('cpu') Line 365: -- To view, visit https://gerrit.ovirt.org/42736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9303b76904ef1344508136343104b37c09d2a370 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
