Zhou Zheng Sheng has posted comments on this change. Change subject: add simple VM creation functional test ......................................................................
Patch Set 3: Verified (1 inline comment) Run through autobuild.sh. install the rpms, start the service, then run this functional test successfully. I should detect if XML RPC binding is enabled. .................................................... File tests/functional/vmTests.py Line 59: Line 60: try: Line 61: assertVdsOK(self.s.create(conf)) Line 62: Line 63: timeout = 65 # seconds In vdsm/vm.py, see Vm.getStats definition. There is a variable definition "GUEST_WAIT_TIMEOUT = 60". VDSM thinks if the VM is up, it is in "Powering Up" state, then after GUEST_WAIT_TIMEOUT seconds, VDSM thinks it is in "Up" state. So I use the magic number 65 here since GUEST_WAIT_TIMEOUT is not exported. Line 64: # wait for VM to come up until timeout Line 65: start = time.time() Line 66: vmUp = False Line 67: guestUp = False -- To view, visit http://gerrit.ovirt.org/7396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Deepak C Shetty <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
