Deepak C Shetty has posted comments on this change.
Change subject: add simple VM creation functional test
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File tests/functional/vmTests.py
Line 44: kernelPath = "/boot/vmlinuz-" + kernelVer
Line 45: initramfsPath = "/boot/initramfs-%s.img" % kernelVer
Line 46: vmid = str(uuid.uuid4())
Line 47: conf = {'display': 'vnc',
Line 48: 'initrd': initramfsPath,
My only intention of suggesting local was to avoid the vnc baggage, not sure
whats the issue here. Let me try to investigate. Not sure if it needs a serial
console/device also in the conf to be present ? Meanwhile can you check with
someone on the list or irc on what could be the issue here ? IMHO, Its better
to keep the test as lite-weight as possible.
Line 49: 'kernel': kernelPath,
Line 50: # Fedora uses dracut to create initramfs. The following
Line 51: # arguments will be interpreted by init scripts
created by
Line 52: # dracut.
--
To view, visit http://gerrit.ovirt.org/7396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb0d86ce20a547ef809d5407fe12d6ade474c4d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
