Nir Soffer has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45752/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 244: proc.start() Line 245: Line 246: needReaping = True Line 247: try: Line 248: if not utils.NoIntrMPConnPoll(pipe, RUN_AS_TIMEOUT): > This name is little ugly and it is also not really generic helper for utils Another nicer option - subclass Pipe, and fix its poll function: class SafePipe(Pipe): def poll(timeout): ... while not Pipe.poll(self, timeout): ... Line 249: try: Line 250: Line 251: os.kill(proc.pid, signal.SIGKILL) Line 252: except OSError as e: -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
