Nir Soffer has posted comments on this change. Change subject: supervdsm: don't let _runAs return early due to EINTR ......................................................................
Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/45752/4/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 122: def safe_poll(mp_connection, timeout): Line 123: """ Line 124: This is a workaround until we get the PEP-475 fix for EINTR. It Line 125: ensures that a multiprocessing.connection.poll() will not return Line 126: before the timeout due to an interruption. Lets document the new behavior: Returns True if there is any data to read from the pipe. Returns False if the timeout expired. Line 127: """ Line 128: deadline = utils.monotonic_time() + timeout Line 129: remaining = timeout Line 130: -- To view, visit https://gerrit.ovirt.org/45752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25af73a8fe67e7bc434f60a7d8492e33dc3b2ffa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
