Nir Soffer has posted comments on this change. Change subject: safelease: Unbreak safelease on systemd ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/45963/3//COMMIT_MSG Commit Message: Line 7: safelease: Unbreak safelease on systemd Line 8: Line 9: spmprotect.sh depends on Vdsm pid file for fencing Vdsm when the SPM Line 10: lease cannot be renewed. However, on systemd, we do not create Vdsm pid file. Line 11: When spmprotect try to fence Vdsm it fails and reboot the host, killing all > reboots Thanks, will fix Line 12: running vms. This issue effects only v1 storage domains, typically old Line 13: systems using dc compatibility version 3.0. Line 14: Line 15: Now we pass vdsm pid to spmprotect.sh helper script via command line Line 13: systems using dc compatibility version 3.0. Line 14: Line 15: Now we pass vdsm pid to spmprotect.sh helper script via command line Line 16: parameter, restoring safelease operation. Adding another argument to Line 17: is ugly, but but I don't want to make risky changes to this delicate and > two buts Thanks, will fix Line 18: critical code. Line 19: Line 20: Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Line 21: Bug-Url: https://bugzilla.redhat.com/1222564 -- To view, visit https://gerrit.ovirt.org/45963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
