Dan Kenigsberg has submitted this change and it was merged. Change subject: safelease: Unbreak safelease on systemd ......................................................................
safelease: Unbreak safelease on systemd spmprotect.sh depends on Vdsm pid file for fencing Vdsm when the SPM lease cannot be renewed. However, on systemd, we do not create Vdsm pid file. When spmprotect tries to fence Vdsm it fails and reboots the host, killing all running vms. This issue effects only v1 storage domains, typically old systems using dc compatibility version 3.0. Now we pass vdsm pid to spmprotect.sh helper script via command line argument, restoring safelease operation. Adding another argument to a script with 9 arguments is ugly, but I don't want to make risky changes to this delicate and critical code. Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Bug-Url: https://bugzilla.redhat.com/1222564 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/45963 Continuous-Integration: Jenkins CI Reviewed-by: Allon Mureinik <amure...@redhat.com> Reviewed-by: Adam Litke <ali...@redhat.com> --- M vdsm/storage/clusterlock.py M vdsm/storage/protect/spmprotect.sh.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I230b6909781269531eab3d71b516b28ab22de856 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
