Saggi Mizrahi has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
I also don't like you adding a another metadata entry. Is it really necessary,
I remember talking to you about how that is problematic.
....................................................
Commit Message
Line 18:
Line 19: This patch attempts to re-use nfsSD core logic to support
Line 20: domain of type GLUSTERFS_DOMAIN.
Line 21:
Line 22: v2:
No need to keep the changelog in the commit message
Line 23: Using different key drive['vmVolInfo'] instead of 'path'
Line 24: Addressed most of federico's comments
Line 25: v3:
Line 26: Addressed federico's comments
....................................................
File vdsm/storage/blockSD.py
Line 469: t = time.time()
Line 470: misc.readfile(lvm.lvPath(self.sdUUID, sd.METADATA), 4096)
Line 471: return time.time() - t
Line 472:
Line 473:
How is removing that method related?
Line 474: def getVolumeClass(self):
Line 475: """
Line 476: Return a type specific volume generator object
Line 477: """
....................................................
File vdsm/storage/hsm.py
Line 124: # FCP domain shouldn't even be on the list but VDSM use to just
Line 125: # accept this type as iscsi so we are stuck with it
Line 126: sd.FCP_DOMAIN: 'iscsi',
Line 127: sd.POSIXFS_DOMAIN: 'posixfs',
Line 128: sd.GLUSTERFS_DOMAIN: 'posixfs' }
Why is this here?
Line 129:
Line 130: def _BCInitiatorNameResolve(ifaceName):
Line 131: if not ifaceName:
Line 132: return iscsi.IscsiInterface('default')
....................................................
File vdsm/storage/nfsSD.py
Line 122: def getVolumeClass(self):
Line 123: """
Line 124: Return a type specific volume generator object
Line 125: """
Line 126: if self.getMetaParam(sd.DMDK_TYPE) == sd.GLUSTERFS_DOMAIN:
Use an accessor
Line 127: return glusterVolume.GlusterVolume
Line 128: else:
Line 129: return fileSD.FileStorageDomain.getVolumeClass(self)
Line 130:
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
