Bala.FA has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/glusterVolume.py
Line 21: VOLUME_TRANS_MAP = {'TCP': 'socket', 'RDMA': 'rdma'}
Line 22:
Line 23: # Extract the volume's transport using gluster cli
Line 24: svdsmProxy = svdsm.getProxy()
Line 25: volInfo = svdsmProxy.glusterVolumeInfo(volname)
glusterVolumeInfo (and other gluster methods) are available only if
vdsm-gluster is available in the system. If no gluster module, there will be
an exception thrown here.
Its better to check gluster module availability something like
try:
from gluster import cli as gcli
_glusterEnabled = True
except ImportError:
_glusterEnabled = False
Line 26: volTrans =
VOLUME_TRANS_MAP[volInfo[volname]['transportType'][0]]
Line 27:
Line 28: # Use default port
Line 29: volPort = "0"
--
To view, visit http://gerrit.ovirt.org/6856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
