Yaniv Bronhaim has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/45738/15/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 666: execCmdLogger.debug(cmdutils.command_log_line(printable, cwd=cwd)) Line 667: Line 668: p = CPopen(command, close_fds=True, cwd=cwd, env=env, Line 669: deathSignal=deathSignal, childUmask=childUmask, Line 670: resetCpuAffinity=resetCpuAffinity) having a wrapper process makes it easier - no cpopen changes, can be used later with python3. why not? it can be used also for the umask modification Line 671: if not sync: Line 672: p = AsyncProc(p) Line 673: if data is not None: Line 674: p.stdin.write(data) -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
