Nir Soffer has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/45738/15/tests/tasksetTests.py File tests/tasksetTests.py: Line 68: self.assertEqual(taskset.get(self.proc.pid), cpu_list) Line 69: Line 70: def test_set_from_child(self): Line 71: Line 72: cpu_list = ['0'] > oh, not a fail cases, only test once the option of pinning the process for Makes sense, but this tests will work only on machine with more then one cpu (usually any machine, but you cannot the configuration of a CI slave vm). So this test should be skipped if running with single cpu. Line 73: Line 74: def _run_helper(): Line 75: # avoid race on startup: first do taskset, then notify Line 76: taskset.set(os.getpid(), cpu_list) -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
