Dan Kenigsberg has posted comments on this change.

Change subject: automation: add build_artifacts
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/46135/3/automation/check-patch.sh
File automation/check-patch.sh:

Line 2: 
Line 3: set -xe
Line 4: 
Line 5: export NOSE_SKIP_STRESS_TESTS=1
Line 6: # nose will produce nosetests.xml with tests results 
trailing spaces are evil.
Line 7: export NOSE_WITH_XUNIT=1 
Line 8: # this redefines 'ugly' but looks like NOSE_EXCLUDE works at test 
method level,
Line 9: # not at module neither at testcase level, so we have no choice but 
this.
Line 10: export NOSE_EXCLUDE="\


Line 17: "
Line 18: 
Line 19: ./autogen.sh --system --enable-hooks
Line 20: make check
Line 21: cp tests/nosetests.xml $EXPORTS/
can we make nosetests.xml changes in a separate patch (Ido's)?

I'd like to understand what collects this xml and where it is presented.
Line 22: 
Line 23: ./automation/build-artifacts.sh
Line 24: 
Line 25: # if specfile was changed, try to install all builded packages


-- 
To view, visit https://gerrit.ovirt.org/46135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to