Ondřej Svoboda has posted comments on this change. Change subject: automation: add build_artifacts ......................................................................
Patch Set 5: Code-Review-1 (8 comments) Mostly typos/unclear comments and $distro question. Thanks for the work! :-) https://gerrit.ovirt.org/#/c/46135/5//COMMIT_MSG Commit Message: Line 10: build builds Line 12: run runs Line 13: builded created https://gerrit.ovirt.org/#/c/46135/5/automation/build-artifacts.sh File automation/build-artifacts.sh: Line 10: can be already may already have been executed? Line 16: done elsewhere Is this a TODO or a note about a path that tests will be run in? https://gerrit.ovirt.org/#/c/46135/5/automation/check-patch.repos.fc21 File automation/check-patch.repos.fc21: Line 3: fedora-21 Isn't $distro == "fedora-21"? Is it possible to use $distro also in other repo files? https://gerrit.ovirt.org/#/c/46135/5/automation/check-patch.sh File automation/check-patch.sh: Line 5: Please mind the whitespace. Line 26: builded It's "built" but I would use "created" here :-) -- To view, visit https://gerrit.ovirt.org/46135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia29761aa2ec920db4485bf704926b67e0d9851b1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
