Yaniv Bronhaim has posted comments on this change. Change subject: tests: ignore empty frame ......................................................................
Patch Set 1: (1 comment) can you add a test so I'll understand how empty frame can appear? https://gerrit.ovirt.org/#/c/42919/1/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 355: parser.parse(data) Line 356: Line 357: while parser.pending > 0: Line 358: frame = parser.popFrame() Line 359: if frame is not None: > If there is premature connection close be the client the code can end up wi I would try to avoid having such scenario because it sounds wrong behavior to produce empty frame :| Line 360: self._frame_handler.handle_frame(self, frame) Line 361: Line 362: def popFrame(self): Line 363: return self._parser.popFrame() -- To view, visit https://gerrit.ovirt.org/42919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34566c77e965c46b3aff3045abb867f4856384ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
