Piotr Kliczewski has posted comments on this change. Change subject: tests: ignore empty frame ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42919/1/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 355: parser.parse(data) Line 356: Line 357: while parser.pending > 0: Line 358: frame = parser.popFrame() Line 359: if frame is not None: > I would try to avoid having such scenario because it sounds wrong behavior This patch was pushed because from time to time there were issues when building in jenkins. Now that we moved the tests to integration dir and we haven't merged UT tests we do not see this issue. I do not have clear reproducer for it. Line 360: self._frame_handler.handle_frame(self, frame) Line 361: Line 362: def popFrame(self): Line 363: return self._parser.popFrame() -- To view, visit https://gerrit.ovirt.org/42919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34566c77e965c46b3aff3045abb867f4856384ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
