Francesco Romani has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 16: (3 comments) https://gerrit.ovirt.org/#/c/45738/16/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 137: EXT_SU = '@SU_PATH@' Line 138: EXT_SUDO = '@SUDO_PATH@' Line 139: Line 140: EXT_TAR = '@TAR_PATH@' Line 141: EXT_TASKSET = '@TASKSET_PATH@' > it shouldn't be hard to avoid it. I think you can import taskset in cmdutil We'll need to move all the instances of CommandPath into another module. As-is: - taskset.py needs utils.py (execCmd) - cmdutils.py will need taskset.py (for the path of the executable, to build the command) - utils.py needs cmdutils.py (execCmd) Line 142: EXT_TUNE2FS = '@TUNE2FS_PATH@' Line 143: Line 144: EXT_UMOUNT = '@UMOUNT_PATH@' Line 145: https://gerrit.ovirt.org/#/c/45738/16/tests/tasksetTests.py File tests/tasksetTests.py: Line 30: from testlib import VdsmTestCase Line 31: from testlib import permutations, expandPermutations Line 32: Line 33: Line 34: _CPU_COMBINATIONS = ([['0']], [['0', '3']], [['1', '2']]) > I wonder if it won't cause troubles in out jenkins machines which might use check validate_running_with_enough_cpus below :) Line 35: Line 36: Line 37: @expandPermutations Line 38: class AffinityTests(VdsmTestCase): https://gerrit.ovirt.org/#/c/45738/16/tests/utilsTests.py File tests/utilsTests.py: Line 80: Line 81: def test(self): Line 82: args = ["sleep", "3"] Line 83: sproc = utils.execCmd(args, sync=False) Line 84: > redundant relic of past versions. Will remove. Line 85: stats = utils.pidStat(sproc.pid) Line 86: pid = int(stats.pid) Line 87: # procName comes in the format of (procname) Line 88: name = stats.comm -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
