Yaniv Bronhaim has posted comments on this change. Change subject: Libvirt service engagement workaround ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 459: Line 460: startout=`/sbin/initctl start libvirtd 2>&1` Line 461: if [[ "$?" -eq 0 || "$startout" =~ .*already\ running.* ]]; Line 462: then Line 463: await_libvirt_start_workaround why don't you just put 5sec sleep here and add a condition that verifies if libvirtd is running (if pgrep libvirtd then; continue else return 1 fi) instead of this unnecessary loop .. it's not realtime process, we can wait 5 sec when we need to start libvirt (it rarely happens), and if libvirt is still not running you can do whatever you want (even ignore it and continue, as you do here :)) Line 464: return 0 Line 465: else Line 466: echo "$startout" >&2 Line 467: return 1 -- To view, visit http://gerrit.ovirt.org/7361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f6fb1ef12caeca3a47adec206b653932026634f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
