Francesco Romani has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/45738/23/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 625: self._poller.close() Line 626: Line 627: Line 628: _ANY_CPU = ["0-%d" % (os.sysconf('SC_NPROCESSORS_ONLN') - 1)] Line 629: _USING_CPU_AFFINITY = config.get('vars', 'cpu_affinity') != "" > We have different ways to tell if we are using cpu affinity. I agree. But on second thought, on vdsm/vdsm I was just fearing the impossible, because I can't think of any case on which we can have cpu_affinity != "" and not cpu_set I can think of a couple of evil inputs on which we should throw an error, and we do. Thus, I'll just remove the useless extra check in vdsm/vdsm. Line 630: Line 631: Line 632: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, Line 633: printable=None, env=None, sync=True, nice=None, ioclass=None, https://gerrit.ovirt.org/#/c/45738/23/vdsm/vdsm File vdsm/vdsm: Line 236: return Line 237: Line 238: cpu_set = frozenset(int(cpu.strip()) for cpu in cpu_affinity.split(",")) Line 239: if not cpu_set: Line 240: return > Is this possible? nope, it was me being overzelous. Will remove. Line 241: Line 242: log = logging.getLogger('vds') Line 243: log.info('VDSM will run with cpu affinity: %s', cpu_set) Line 244: -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
