Nir Soffer has posted comments on this change. Change subject: scale: limit cpu usage using cpu-affinity ......................................................................
Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/45738/21/tests/tasksetTests.py File tests/tasksetTests.py: Line 81: def test_set_from_child(self, cpu_list): Line 82: Line 83: validate_running_with_enough_cpus(cpu_list) Line 84: Line 85: def _run_helper(): > OK, but I was asked to inline it in a former review :) I think simple function used by all tests will be good. Something like: def run_child(cpu_list=None): if cpu_list: taskset.set(os.getpid(), cpu_list) self.running.set() self.stop.wait() Line 86: # avoid race on startup: first do taskset, then notify Line 87: taskset.set(os.getpid(), cpu_list) Line 88: self.running.set() Line 89: while not self.stop.is_set(): -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
