Nir Soffer has posted comments on this change.

Change subject: v2v: Fix getExternalVMs if getting disk size failed
......................................................................


Patch Set 2: Verified+1

Tested by user, log prove that this error is eliminated now.

Libvirt fails now when trying to get XMLDec for some other vm, we will have to 
handle this separately.

 Thread-1076::ERROR::2015-09-23 10:18:51,778::v2v::682::root::(_add_disk_info) 
Error getting disk size
 Traceback (most recent call last):
  File "/usr/share/vdsm/v2v.py", line 679, in _add_disk_info
    vol = conn.storageVolLookupByPath(disk['alias'])
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 4308, in 
storageVolLookupByPath
    if ret is None:raise libvirtError('virStorageVolLookupByPath() failed', 
conn=self)
 libvirtError: An error occurred, but the cause is unknown
 Thread-1076::ERROR::2015-09-23 
10:18:52,604::__init__::526::jsonrpc.JsonRpcServer::(_serveRequest) Internal  
server error
 Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 521, in 
_serveRequest
    res = method(**params)
  File "/usr/share/vdsm/rpc/Bridge.py", line 273, in _dynamicMethod
    result = fn(*methodArgs)
  File "/usr/share/vdsm/API.py", line 1436, in getExternalVMs
    return v2v.get_external_vms(uri, username, password)
  File "/usr/share/vdsm/v2v.py", line 152, in get_external_vms
    root = ET.fromstring(vm.XMLDesc(0))
  File "/usr/lib64/python2.7/site-packages/libvirt.py", line 478, in XMLDesc
    if ret is None: raise libvirtError ('virDomainGetXMLDesc() failed', 
dom=self)
 libvirtError: internal error: Invalid or not yet handled value 
'emptyBackingString' for VMX entry  'ide1:0.fileName' for device type 
'cdrom-image'

-- 
To view, visit https://gerrit.ovirt.org/46540
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e91190a255a4d9bd2f474e125c49b18e3d3bfd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to