Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
......................................................................
v2v: Fix getExternalVMs if getting disk size failed
In getExternalVMs we try to report the disk size, but if this info is
not available for certain disk, we continue to collect info about other
disks. Due to incorrect error handling, the request was aborted after
the first error:
File "/usr/share/vdsm/v2v.py", line 684, in _add_disk_info
disk['capacity'] = str(capacity)
UnboundLocalError: local variable 'capacity' referenced before assignment
This patch fixes the error handling so failure to get disk size would
not fail the entire request.
Change-Id: I7e91190a255a4d9bd2f474e125c49b18e3d3bfd4
Reported-by: Ian Fraser <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1265556
Backport-to: 3.6
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/46540
Reviewed-by: Francesco Romani <[email protected]>
Continuous-Integration: Jenkins CI
---
M vdsm/v2v.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e91190a255a4d9bd2f474e125c49b18e3d3bfd4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
