Ido Barkan has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46430/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 536: """ Line 537: underlying_device = net_attrs['iface'] Line 538: for devices in ('bridges', 'vlans', 'bondings', 'nics'): Line 539: devinfo = netinfo[devices].get(underlying_device) Line 540: if devinfo: > Technically correct, but I used the assumption that _devinfo always returns right Line 541: devinfo['dhcpv4'] = net_attrs['dhcpv4'] Line 542: devinfo['dhcpv6'] = net_attrs['dhcpv6'] Line 543: break Line 544: -- To view, visit https://gerrit.ovirt.org/46430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
