Ondřej Svoboda has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46430/4/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 475: return ' '.join((opt + '=' + val for (opt, val) Line 476: in sorted(opts.iteritems()))) Line 477: Line 478: Line 479: def _dhcp_used(iface, ifaces_with_active_leases, net_attrs, family=4): > let's further simplify this? You are correct, after reverting to using _dhcp_used only in _getNetInfo, net_attrs comes from running config. _dhcp_requested sounds nice but the point of _dhcp_used is to override the simple "iface in ifaces_with_active_leases" test with a False value if a network has bootproto:none/dhcpv6:false. Line 480: if net_attrs is None: Line 481: logging.debug('There is no VDSM network configured on %s.' % iface) Line 482: return iface in ifaces_with_active_leases Line 483: else: -- To view, visit https://gerrit.ovirt.org/46430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
