Nir Soffer has posted comments on this change. Change subject: dispatcher: improve failure logging ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46624/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 45 Line 46 Line 47 Line 48 Line 49 In the original asyncore design, all errors are handled by calling handle_error, so logging errors there should be enough. I'm not sure if this is true for better-asyncore though. -- To view, visit https://gerrit.ovirt.org/46624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d993909a5b42650265d6cf0d0e811d4e98f2b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
