Piotr Kliczewski has posted comments on this change. Change subject: dispatcher: improve failure logging ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/46624/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 45 Line 46 Line 47 Line 48 Line 49 > I agree and we can improve it as well. The issue here was that there were u What you are describing is handle_expt_event not handle_error (asyncore impl). We can't use close only because we need to clean subscriptions. In this patch let's improve logging caught exceptions in handle_error. -- To view, visit https://gerrit.ovirt.org/46624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93d993909a5b42650265d6cf0d0e811d4e98f2b5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
