Francesco Romani has posted comments on this change. Change subject: host stats: Add cpusStatus to vdsStats ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/46270/4/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2072: # the KSM feature (in bytes) Line 2073: # Line 2074: # @memCommitted: Amount of memory committed to running VMs (in MB) Line 2075: # Line 2076: # @onlineCpus: The list of online logical CPUs > I would prefer to be consistent with what we report in getVdsCapabilities ok Line 2077: # (new in version 4.17.2) Line 2078: # Line 2079: # @swapTotal: The total amount of swap space (in MB) Line 2080: # https://gerrit.ovirt.org/#/c/46270/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 619: return None Line 620: Line 621: def get(self): Line 622: stats = self._empty_stats() Line 623: stats['onlineCpus'] = ','.join(_get_online_cpus()) > Just wanted to do it the same way, as we do it in getVdsCapabilities. fair enough for me. Line 624: Line 625: first_sample, last_sample, _ = self._samples.stats() Line 626: if first_sample is None: Line 627: return stats -- To view, visit https://gerrit.ovirt.org/46270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
