Francesco Romani has posted comments on this change.

Change subject: host stats: Add cpusStatus to vdsStats
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/46270/7/tests/samplingTests.py
File tests/samplingTests.py:

Line 271:             self._hs = sampling.HostStatsThread(self.log)
Line 272:             self.assertEquals(self._hs.get(), expected)
Line 273: 
Line 274:     def testCpusStatus(self):
Line 275:         cpusStatus = [True, False, True, False]
do we really need this temporary? Please inline it
Line 276: 
Line 277:         def get():
Line 278:             class LibvirtConnection(object):
Line 279:                 def getCPUMap(self):


-- 
To view, visit https://gerrit.ovirt.org/46270
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roman Mohr <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to