Dan Kenigsberg has posted comments on this change. Change subject: libvirtvm: allow acpi again ......................................................................
Patch Set 1: Zhou, it is also the fault of the reviewer... Please verify this patch, too. Yes, a unit test for the generated domxml may be a good idea, which is pretty hard to implement without re-implementing libvirtvm within the test framework. I have no idea how to design a robust and complete test like that. BTW, it could have been nice if libvirt's domxml verification had warned about the freetext withing <features>. -- To view, visit http://gerrit.ovirt.org/7533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itzik Brown <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
