Zhou Zheng Sheng has posted comments on this change.
Change subject: libvirtvm: allow acpi again
......................................................................
Patch Set 1: Verified
Run through ./autobuild.sh, then I cd to ~/builder and verify the output XML as
follow.
[root@zhshzhouf17 builder]#
PYTHONPATH=$(pwd)/share/vdsm:$(pwd)/lib64/python2.7/site-packages:/usr/lib64/python2.7/site-packages
python
Python 2.7.3 (default, Jul 24 2012, 10:05:38)
[GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from libvirtvm import _DomXML as DomXML
>>> d = {'acpiEnable': 'True', 'smp': '2', 'memSize': 128, 'vmName':
>>> 'rhel6vdsm', 'vmId': '209b27e4-aed3-11e1-a547-00247edb4743'}
>>> domxml = DomXML(d, None)
>>> domxml.appendFeatures()
>>> print domxml.toxml()
<?xml version="1.0" encoding="utf-8"?>
<domain type="kvm">
<name>rhel6vdsm</name>
<uuid>209b27e4-aed3-11e1-a547-00247edb4743</uuid>
<memory>131072</memory>
<currentMemory>131072</currentMemory>
<vcpu>2</vcpu>
<devices/>
<features>
<acpi/>
</features>
</domain>
From the above conversation we can see, we have to invoke appendFeatures() to
let domxml generate the acpi sub node. In my refactor commit which introduced
the bug, I examined the output XML as well but forgot to call appendFeatures()
to verify the <acpi> node, so I did not realize the acpi node was not generated
properly. This patch fix the problem.
--
To view, visit http://gerrit.ovirt.org/7533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I591c40678f030f1bcd4cb7cb42c21907420f7cf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Itzik Brown <[email protected]>
Gerrit-Reviewer: Meni Yakove <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
