Piotr Kliczewski has posted comments on this change. Change subject: stomp: make sure that subscriptions use uniqe id ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46656/2/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 132: self._send_error("Missing destination or subscription id header", Line 133: dispatcher.connection) Line 134: return Line 135: Line 136: if sub_id in self._sub_ids.keys(): > no need to use keys: Done Line 137: self._send_error("Subscription id already exists", Line 138: dispatcher.connection) Line 139: return Line 140: -- To view, visit https://gerrit.ovirt.org/46656 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3883bb68134a6e2cc52cf54ce4027122db8150e9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
