Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Improve utils.retry tests ......................................................................
tests: Improve utils.retry tests We did not have tests for the timeout mechanism. This patch adds 4 tests, revealing issues in the current code: - Test that we bail out when the timeout precisely expires (broken). - Test that we do not wait needlessly if a sleep would make timeout expire (broken). - Test that we do not wait needlessly if deadline has passed when the operation was finished (ok). - Test that we ignore zero timeout (ok). Change-Id: I62062f36e20d263b1aed64135345d496cb7cfd61 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46399 Reviewed-by: Edward Haas <[email protected]> Tested-by: Edward Haas <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/utilsTests.py 1 file changed, 88 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Edward Haas: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62062f36e20d263b1aed64135345d496cb7cfd61 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
