Roman Mohr has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG Commit Message: Line 26: 'nodeIndex': 0}, Line 27: '1': {'cpuIdle': '96.07', Line 28: 'cpuSys': '0.47', Line 29: 'cpuUser': '3.46', Line 30: 'nodeIndex': 0}} > The indentation make it hard to understand this format - it is After thinking about it, I am not for the solution where we have offline cpus in the list: 1) This is definitely not a backward compatible change for clients (Also not for the current engine). 2) The cpu was never in the list when a cpu was already offline before libvirtd came up 3) Is this really nicer for clients? Because in the current implementation they can easily calculate the overall cpu usage by iterating over the list. All fields are mandatory => very easy to use. 4) We also only count online cpu cores in the capabilities call. onlineCpus always has the same number of entries as the value of cpuCores. Any thoughts? Line 31: [...] Line 32: Line 33: When only one CPU out of two has been online before libvird was Line 34: started, vdsm reports: -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roman Mohr <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
