Roman Mohr has posted comments on this change.

Change subject: host stats: Collect stats from online cpu cores only
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/46269/6//COMMIT_MSG
Commit Message:

Line 26:                                           'nodeIndex': 0},
Line 27:                                     '1': {'cpuIdle': '96.07',
Line 28:                                           'cpuSys': '0.47',
Line 29:                                           'cpuUser': '3.46',
Line 30:                                           'nodeIndex': 0}}
> The indentation make it hard to understand this format - it is
Indention improved
Line 31:         [...]
Line 32: 
Line 33: When only one CPU out of two has been online before libvird was
Line 34: started, vdsm reports:


Line 29:                                           'cpuUser': '3.46',
Line 30:                                           'nodeIndex': 0}}
Line 31:         [...]
Line 32: 
Line 33: When only one CPU out of two has been online before libvird was
> typo: libvirtd
Done
Line 34: started, vdsm reports:
Line 35: 
Line 36:  $ vdsClient -s 0 getVdsStats
Line 37:         [...]


-- 
To view, visit https://gerrit.ovirt.org/46269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rm...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roman Mohr <rm...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to