Piotr Kliczewski has posted comments on this change. Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/44689/12/lib/vdsm/sslcompat.py File lib/vdsm/sslcompat.py: Line 21: Line 22: if config.get('vars', 'ssl_implementation') == 'm2c': Line 23: from . import m2cutils as sslutils Line 24: from .m2cutils import SSLHandshakeDispatcher Line 25: from .m2cutils import SSLSocket > this specific change (import order swap) belongs in the parent patch. Done Line 26: else: Line 27: from . import sslutils Line 28: from .sslutils import SSLHandshakeDispatcher Line 29: from ssl import SSLSocket -- To view, visit https://gerrit.ovirt.org/44689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
