Yaniv Bronhaim has posted comments on this change. Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/44689/15/configure.ac File configure.ac: Line 164: , Line 165: [enable_m2c="yes"] Line 166: ) Line 167: AM_CONDITIONAL([M2C], [test "${enable_m2c}" = "yes"]) Line 168: do we really want this? users should know what they want to configure in vdsm.conf. we can alert somehow about it over debian installation that default m2crypto implementation might not work and its recommanded to set it to work with default ssl.. Nir, do you agree with setting it in build time? not that its so important.. I just think that this config value is simple enough to be familiar with. if user knows to run ./configure with --enable-m2c=no , he also can do "vi vdsm.conf" and add whatever he needs. and if not, it can be done by vdsm-tool configure in some shape. I just think its prettier Line 169: # Users and groups Line 170: AC_SUBST([VDSMUSER], [vdsm]) Line 171: AC_SUBST([VDSMGROUP], [kvm]) Line 172: AC_SUBST([METADATAUSER], [vdsm]) -- To view, visit https://gerrit.ovirt.org/44689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
