Dan Kenigsberg has posted comments on this change. Change subject: net: tests: additional tests for host QOS ......................................................................
Patch Set 7: (6 comments) https://gerrit.ovirt.org/#/c/44699/7//COMMIT_MSG Commit Message: Line 9: Those test These tests Line 9: top most topmost https://gerrit.ovirt.org/#/c/44699/7/tests/nettestlib.py File tests/nettestlib.py: Line 98: IPRoute2Error > I assume nothing should go wrong but during development of other tests it m I don't understand Ondra's comment, but I also do not understand why do you swallow the error. If we want to allow for removal of bridge within its context, it's a bit odd. But is it the issue? Line 109: addDevice > Do I get it right that you want to differentiateMethodNames from standalone yes, we should move to pep8_names, but here we inherit from Interface, so the namechange should happen in another patch. Line 126: try: Line 127: yield vlan Line 128: finally: Line 129: try: Line 130: vlan.delDevice() here, too, I don't understand the exception catching. Line 131: except IPRoute2Error: Line 132: pass Line 133: Line 134: https://gerrit.ovirt.org/#/c/44699/7/tests/tcTests.py File tests/tcTests.py: Line 494: cls > "class" is better. I think of "cls" as a reserved word (albeit not enforced actually, "class" is a reserved keyword. cls is cool. klass hurts my eyes. -- To view, visit https://gerrit.ovirt.org/44699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad639a9ad04593cfd477f60a8272614f3446522 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
