Ondřej Svoboda has posted comments on this change. Change subject: net: tests: additional tests for host QOS ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/44699/7/tests/nettestlib.py File tests/nettestlib.py: Line 98: IPRoute2Error > I don't understand Ondra's comment, but I also do not understand why do you My concern was that if the exception swallowing was merged (which by itself is not a good thing unless explained) and I started hacking on some piece of code that would throw IPRoute2Error, it would be harder for me to find out. https://gerrit.ovirt.org/#/c/44699/7/tests/tcTests.py File tests/tcTests.py: Line 494: cls > actually, "class" is a reserved keyword. cls is cool. klass hurts my eyes. What was I thinking! Alright then, I also cannot think of a better name. You know, in the context of @classmethod we use "cls". But suggesting to use "class" is just my bad :-) -- To view, visit https://gerrit.ovirt.org/44699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad639a9ad04593cfd477f60a8272614f3446522 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
