Francesco Romani has posted comments on this change. Change subject: vdsm: isolate fake_kvm into a hook ......................................................................
Patch Set 2: (3 comments) very nice! https://gerrit.ovirt.org/#/c/46897/2/debian/control File debian/control: Line 200: Description: VDSM hook that intercepts capabilities returned by VDSM to allow Line 201: faking the target architecture. Line 202: To enable this hook on your host, set vars.fake_kvm_support=true and target Line 203: architecture in vars.fake_kvm_architecture in your /etc/vdsm/vdsm.conf. Line 204: trailing whitespace Line 205: Line 206: Package: vdsm-hook-fakevmstats Line 207: Architecture: all Line 208: Depends: ${shlibs:Depends}, ${misc:Depends}, python (>=2.7.3), vdsm (>= ${source:Version}) https://gerrit.ovirt.org/#/c/46897/2/debian/vdsm-hook-fakearch.install File debian/vdsm-hook-fakearch.install: Line 1: usr/libexec/vdsm/hooks/after_get_caps/10_fakekvm "fakearch", I guess https://gerrit.ovirt.org/#/c/46897/2/vdsm.spec.in File vdsm.spec.in: Line 408: %description hook-fakearch Line 409: VDSM hook that intercepts capabilities returned by VDSM to allow faking the Line 410: target architecture. Line 411: To enable this hook on your host, set vars.fake_kvm_support=true and target Line 412: architecture in vars.fake_kvm_architecture in your /etc/vdsm/vdsm.conf. not sure this hook should be configured using the main vdsm.conf. Maybe, for starters, a new [fake] section? ([fakearch]?) Line 413: Line 414: %package hook-fakevmstats Line 415: Summary: Generate random VM statistics Line 416: Requires: %{name} -- To view, visit https://gerrit.ovirt.org/46897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
