Francesco Romani has posted comments on this change. Change subject: asyncore: use default handing of read event ......................................................................
Patch Set 1: Code-Review-1 (1 comment) partially related comment https://gerrit.ovirt.org/#/c/46911/1/tests/integration/jsonRpcTests.py File tests/integration/jsonRpcTests.py: Line 75: def unregister_server_address(self): Line 76: self.server_address = None Line 77: Line 78: Line 79: def getInstance(cls=None): > Not sure whether it should be part of this fix. I saw that the test failed Let's fix it in a separate patch. My (very) wild guess is that we should probably add a getInstance classmethod in tests/integration/jsonRpcHelper:FakeClientIf, always returning self (or something like it) Line 80: return FakeClientIf() Line 81: Line 82: Line 83: @expandPermutations -- To view, visit https://gerrit.ovirt.org/46911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dd6856f5c08da459478c60ac1fe7881baa69a2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
