Piotr Kliczewski has posted comments on this change. Change subject: asyncore: use default handing of read event ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46911/2/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 94 Line 95 Line 96 Line 97 Line 98 > This part was always wrong - calling handle_read more then once is evil and This is exactly what I noticed. We do not need our own implementation because asyncore implementation works OK for us. -- To view, visit https://gerrit.ovirt.org/46911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dd6856f5c08da459478c60ac1fe7881baa69a2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
