Francesco Romani has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting ......................................................................
Patch Set 2: Code-Review-1 (1 comment) seems ok, but please make sure vdsm/rpc/vdsmapi-schema.json is updated. -1 for visibility. https://gerrit.ovirt.org/#/c/46846/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 93: self._dstqemu = dstqemu Line 94: self._downtime = kwargs.get('downtime') or \ Line 95: config.get('vars', 'migration_downtime') Line 96: self._maxBandwidth = kwargs.get('maxBandwidth') or \ Line 97: config.getint('vars', 'migration_max_bandwidth') let's use: self._maxBandwidth = int( kwargs.get('maxBandiwidth') or config.getint('vars', 'migration_max_bandwidth') ) so once set, the value will always have the right type. For 4.0, or when we can break backward compat: let's move all the migration-related tunables in a new section [migration] Line 98: self._autoConverge = autoConverge Line 99: self._compressed = compressed Line 100: self.status = { Line 101: 'status': { -- To view, visit https://gerrit.ovirt.org/46846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d99e488a9e8bb80b0c3c069628171c666f3bf4b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
