Francesco Romani has posted comments on this change.

Change subject: migration: Add support for max migration bandwidth setting
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

almost there, another tiny bit is missing in schema.json, the rest looks fine

https://gerrit.ovirt.org/#/c/46846/5/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 7709: #                   (new in version 4.17.0)
Line 7710: #
Line 7711: # @autoConverge:    #optional Force convergence during live 
migration.
Line 7712: #                   (new in version 4.17.0)
Line 7713: # @maxBandwidth:    #optional maximal bandwidth used by the 
migration (MiB/s)
let's also add the

  (new in version 4.1x.y)

bit
Line 7714: #
Line 7715: # Since: 4.10.0
Line 7716: ##
Line 7717: {'type': 'MigrateParams',


-- 
To view, visit https://gerrit.ovirt.org/46846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d99e488a9e8bb80b0c3c069628171c666f3bf4b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to