Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan
Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/7617
to review the following change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
......................................................................
glusterHostsList verb returns local hostname as IP address or FQDN
Change-Id: Id0f96a6ac76fd9ac7ea30fa1c707d61e9f05eb42
Signed-off-by: Bala.FA <[email protected]>
---
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/7617/1
diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index dcd8eda..659eef3 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -732,7 +732,8 @@
"""
rc, out, err = _execGluster(_getGlusterPeerCmd() + ["status"])
if rc:
- raise ge.GlusterHostListFailedException(rc, out, err)
+ raise ge.GlusterHostsListFailedException(rc, out, err)
else:
- return _parsePeerStatus(out, _getGlusterHostName(),
+ return _parsePeerStatus(out,
+ _getLocalIpAddress() or _getGlusterHostName(),
_getGlusterUuid(), HostStatus.CONNECTED)
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 3b8a978..abe2ffb 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -364,6 +364,6 @@
message = "Remove host failed"
-class GlusterHostListFailedException(GlusterHostException):
+class GlusterHostsListFailedException(GlusterHostException):
code = 4407
- message = "Host list failed"
+ message = "Hosts list failed"
--
To view, visit http://gerrit.ovirt.org/7617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0f96a6ac76fd9ac7ea30fa1c707d61e9f05eb42
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
