Bala.FA has posted comments on this change.
Change subject: glusterHostsList verb uses gluster cli xml output.
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File vdsm/gluster/cli.py
Line 541: return hostList
Line 542:
Line 543:
Line 544: @exportToSuperVdsm
Line 545: def peerStatus():
'gluster peer status' gluster gli command lists servers in the gluster cluster
except the host where we run the command. But the engine side, its required to
give all servers. This is handled by adding current host detail by default.
If you feel moving this local host addition to api.py, I can do that.
Line 546: """
Line 547: Returns:
Line 548: [{'hostname': HOSTNAME, 'uuid': UUID, 'status': STATE}, ...]
Line 549: """
Line 553: except ge.GlusterCmdFailedException, e:
Line 554: raise ge.GlusterHostsListFailedException(rc=e.rc, err=e.err)
Line 555: try:
Line 556: return _parsePeerStatus(xmltree,
Line 557: _getLocalIpAddress() or
_getGlusterHostName(),
In gluster sync functionality in engine side, its unable to identify a host
with its fqdn name, but can do with any one of the ip address of the host.
Based on this, _getLocalIpAddress() prefer than _getGlusterHostName()
Yes. This is not related to xml. I will move it to separate patch.
Line 558: _getGlusterUuid(),
HostStatus.CONNECTED)
Line 559: except:
Line 555: try:
Line 556: return _parsePeerStatus(xmltree,
Line 557: _getLocalIpAddress() or
_getGlusterHostName(),
Line 558: _getGlusterUuid(),
HostStatus.CONNECTED)
Line 559: except:
Done
--
To view, visit http://gerrit.ovirt.org/7617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f96a6ac76fd9ac7ea30fa1c707d61e9f05eb42
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
