Dan Kenigsberg has uploaded a new change for review. Change subject: tc: avoid adding non-existing devices to filter ......................................................................
tc: avoid adding non-existing devices to filter When a mirroring target dies, its tap device are removed. On `tc filter show`, the tap device name is replaced with a string like `if17`, which is not a name of an existing device. This patch is somewhat racy, as another qemu may die just before the new filter is set. Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm/tc.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/7631/1 diff --git a/vdsm/tc.py b/vdsm/tc.py index 47a7b96..d363d35 100644 --- a/vdsm/tc.py +++ b/vdsm/tc.py @@ -20,6 +20,8 @@ from collections import namedtuple +import ethtool + import storage.misc from vdsm.constants import EXT_TC, EXT_IFCONFIG @@ -55,6 +57,7 @@ acts = set(filt.actions) acts.discard(MirredAction(target)) + acts.update(ethtool.get_devices()) if acts: filt = Filter(prio=filt.prio, handle=filt.handle, actions=acts) -- To view, visit http://gerrit.ovirt.org/7631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9c1b459557985a3a894f182880411889f2c8a06f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
