Yaniv Bronhaim has posted comments on this change. Change subject: ssl: runtime config to choose implementation ......................................................................
Patch Set 15: (2 comments) do you verify it over debian? https://gerrit.ovirt.org/#/c/44689/15/configure.ac File configure.ac: Line 164: , Line 165: [enable_m2c="yes"] Line 166: ) Line 167: AM_CONDITIONAL([M2C], [test "${enable_m2c}" = "yes"]) Line 168: > Nir and Piotr, good point. Fine by me. still no. m2crypto is available on system vdsm runs on - rpm based and debian based. user need to modify vdsm.conf and that's it. I don't see any advantages for this logic - which relevant only to rpm anyway Line 169: # Users and groups Line 170: AC_SUBST([VDSMUSER], [vdsm]) Line 171: AC_SUBST([VDSMGROUP], [kvm]) Line 172: AC_SUBST([METADATAUSER], [vdsm]) https://gerrit.ovirt.org/#/c/44689/15/vdsm.spec.in File vdsm.spec.in: Line 628: sed -i -e 's/^software_version =.*/software_version = "'"${baseversion}"'"/' \ Line 629: -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \ Line 630: -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' vdsm/dsaversion.py Line 631: Line 632: sed -i -e 's/@SSl_IMPLEMENTATION@/%{ssl_implementation}/g' lib/vdsm/config.py don't you need to do it in debian as well? Line 633: Line 634: %install Line 635: rm -rf %{buildroot} Line 636: make DESTDIR=%{buildroot} install -- To view, visit https://gerrit.ovirt.org/44689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
