Nir Soffer has posted comments on this change. Change subject: muiltipath: Unbreak configure on ovirt node ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46397/2/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 126: utils.unpersist(_CONF_FILE) Line 127: os.rename(f.name, _CONF_FILE) Line 128: utils.persist(_CONF_FILE) Line 129: except: Line 130: os.unlink(f.name) > this is not pretty if utils.persist raises, after rename has eliminated f.n Right, will fix in next version. Line 131: raise Line 132: Line 133: # Flush all unused multipath device maps Line 134: utils.execCmd([constants.EXT_MULTIPATH, "-F"]) -- To view, visit https://gerrit.ovirt.org/46397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83822494dd1c98105aac081df0bdf4ec2e39a548 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
