Dan Kenigsberg has submitted this change and it was merged. Change subject: muiltipath: Unbreak configure on ovirt node ......................................................................
muiltipath: Unbreak configure on ovirt node In commit commit 4d51f0df2d (multipath: Write multipath.conf atomically) we replaced file copy with rename. This make the operation atomic but it does not work on ovirt node, because multipath.conf is a bind mount. On ovirt node we cannot do atomic rename; we must unpersist the multipath.conf before the rename and persist it after the rename. If we crash after unpersisting and before persisting multipath.conf will be missing after a reboot. We can do nothing about this. Other platforms are not effected since utils.unpersist() and utils.persit() do nothing on other platforms. Change-Id: I83822494dd1c98105aac081df0bdf4ec2e39a548 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/46397 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurators/multipath.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83822494dd1c98105aac081df0bdf4ec2e39a548 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
